Allow using C++23 #5283
Allow using C++23 #5283
Conversation
masterleinad
force-pushed
the
allow_cxx23
branch
from
adade9f
to
94ddaeb
Compare
|
This is good enough for me now. To have at least one C++20 and one C++23 it seemed easiest to pick CI builds that require very recent compilers anyway. I first played with |
|
The |
cmake/kokkos_pick_cxx_std.cmake
Outdated
| ELSEIF(${KOKKOS_CXX_STANDARD} STREQUAL "c++20") | ||
| MESSAGE(WARNING "Deprecated Kokkos C++ standard set as 'c++20'. Use '20' instead.") | ||
| SET(KOKKOS_CXX_STANDARD "20") | ||
| ELSEIF(${KOKKOS_CXX_STANDARD} STREQUAL "c++23") | ||
| MESSAGE(WARNING "Deprecated Kokkos C++ standard set as 'c++23'. Use '23' instead.") | ||
| SET(KOKKOS_CXX_STANDARD "23") |
There was a problem hiding this comment.
I'd argue for turning the deprecation message above into an error and remove that block altogether.
There was a problem hiding this comment.
Let's discuss that in another pull request.
There was a problem hiding this comment.
yeah I do want one C++23 build, but its fine with me if that is a GCC build on github. using GCC 12 preferrably.
| #if (defined(KOKKOS_ENABLE_CXX17) || defined(KOKKOS_ENABLE_CXX20) || \ | ||
| defined(KOKKOS_ENABLE_CXX23)) && \ |
There was a problem hiding this comment.
All these places are already (supposed to be part of #5295) and I would assume any cleanup after requiring C++17 to search for KOKKOS_ENABLE_CXX17 anyway.
| @@ -644,7 +645,8 @@ static constexpr bool kokkos_omp_on_host() { return false; } | |||
| #define KOKKOS_ENABLE_CUDA_LDG_INTRINSIC | |||
| #endif | |||
|
|
|||
| #if defined(KOKKOS_ENABLE_CXX17) || defined(KOKKOS_ENABLE_CXX20) | |||
| #if defined(KOKKOS_ENABLE_CXX17) || defined(KOKKOS_ENABLE_CXX20) || \ | |||
| defined(KOKKOS_ENABLE_CXX23) | |||
| #if defined(KOKKOS_ENABLE_CXX17) || defined(KOKKOS_ENABLE_CXX20) || \ | ||
| defined(KOKKOS_ENABLE_CXX23) |
This still assumes that C++14 is allowed.