Turn setting Kokkos_CXX_STANDARD into an error #5293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
Jul 29, 2022
dalg24
approved these changes
Jul 29, 2022
nliber
approved these changes
Jul 29, 2022
ajpowelsnl
reviewed
Jul 29, 2022
| ENDIF() | ||
|
|
||
| IF (NOT KOKKOS_CXX_STANDARD AND NOT CMAKE_CXX_STANDARD) | ||
| MESSAGE(STATUS "Setting default Kokkos CXX standard to 14") | ||
| IF (NOT CMAKE_CXX_STANDARD) |
There was a problem hiding this comment.
Would it be more intuitive to flip this logic, instead saying:
IF (CMAKE_CXX_STANDARD) SET(KOKKOS_CXX_STANDARD ${CMAKE_CXX_STANDARD}) ELSE() SET(KOKKOS_CXX_STANDARD "14") ENDIF() MESSAGE(STATUS "Setting default Kokkos CXX standard to ${KOKKOS_CXX_STANDARD}")
There was a problem hiding this comment.
I don't see much of a difference honestly.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #5283 (comment).