-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow linking against build tree #6078
Conversation
The only thing that may be needed for building Kokkos inside of Trilinos with the native Kokkos CMake build system is the location of the KokkosConfig.cmake file for the build tree. TriBITS assumes these files are stored under Hopefully this is a simple tweak to the Kokkos CMake files to be able to specify the exact location of where to put this KokkosConfig.cmake file for the build tree. |
It seems that trilinos/Trilinos#11779 also works with these files in
|
@masterleinad, the standard build and install of Trilinos packages do not utilize the files under I will add a test to the TrilinosInstallTests package to demonstrate and protect this functionality. Also, these files are utilized for incremental configures and builds as described in Use Case 1: Configure/build all packages then re-configure subset of downstream packages as part of: I have not added the official documentation for this use case to TriBITS yet, but this use case will speed up re-configures/re-builds for developers that have a local build and just want to reconfigure/rebuild a small subset of downstream packages. (For a small TriBITS project like Trilinos this is not that big of a deal but for larger TriBITS projects like CASL VERA, this will have greater impact on reducing reconfigure times and build-time dependency computation.) |
HIP builds timed out but that's ok |
* Allow linking against build tree * Use Kokkos_BINARY_DIR instead of CMAKE_BINARY_DIR
This pull request makes it possible to link against
Kokkos
using the build tree which is, e.g., very useful when trying out how changes inKokkos
influence downstream code (and having changes ready to create pull requests).This is necessary for trilinos/Trilinos#11779.