Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also create symlinks for CMake configuration files to cmake_packages/Kokkos for TriBITS #6163

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Also create symlinks for CMake configuration files to cmake_packages/Kokkos for TriBITS #6163

merged 2 commits into from
Jun 2, 2023

Conversation

masterleinad
Copy link
Contributor

Follow-up to #6078, addressing #6078 (comment).
To be TriBITS-compliant, we need to also provide our configuration files at ${CMAKE_BINARY_DIR}/cmake_packages/Kokkos.

@dalg24
Copy link
Member

dalg24 commented May 25, 2023

@bartlettroscoe please review. Do you see any issue with using symlinks?

nmm0
nmm0 reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@nmm0 nmm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a TriBITS requirement for build-tree usage or do we also need to do this for installs?

@masterleinad
Copy link
Contributor Author

Is this a TriBITS requirement for build-tree usage or do we also need to do this for installs?

This is for linking against a Trilinos/TriBITS build tree, see #6078 (comment).

@bartlettroscoe
Copy link
Contributor

bartlettroscoe commented May 26, 2023 •
edited

@bartlettroscoe please review. Do you see any issue with using symlinks?

@dalg24, I don't see any reason that would not work. There are no relative directory references in KokkosConfig.cmake that would get confused by this, are there? (And since the build dir is not expected to be relocatable, there is no reason to use relative paths in the <Package>Config.cmake files generated in the build dir.)

@cz4rs cz4rs self-requested a review May 31, 2023 19:51
cz4rs
cz4rs approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dalg24
Copy link
Member

dalg24 commented Jun 2, 2023

Ignoring HIP timeouts

@dalg24 dalg24 merged commit 65ffe4c into kokkos:develop Jun 2, 2023
27 of 28 checks passed
@ndellingwood ndellingwood mentioned this pull request Jun 5, 2023
Closed
@nmm0 nmm0 mentioned this pull request Jun 16, 2023
Closed
nliber pushed a commit to nliber/kokkos that referenced this pull request Jun 22, 2023
@masterleinad @nliber
Also create symlinks for CMake configuration files to cmake_packages/…
01a5966 
…Kokkos for TriBITS (kokkos#6163)

* Also create symlinks for CMake configuration files to cmake_packages/Kokkos for TriBITS

* Also link KokkosConfigVersion.cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmm0 nmm0 nmm0 left review comments

@dalg24 dalg24 dalg24 approved these changes

@cz4rs cz4rs cz4rs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@masterleinad @dalg24 @bartlettroscoe @cz4rs @nmm0