#5635: Serial/OpenMP: Parallel_scan with return value for TeamThreadRange

[thearusable]

Related to #5635

[fnrizzi]

see comments

[fnrizzi]

please improve description

[fnrizzi]

i think we are missing some guards in the test, aren't we? how about openmp and threads?
https://kokkos.github.io/kokkos-core-wiki/keywords.html#device-backends

[thearusable]

@fnrizzi Yes I missed some guards, now they are added. Also I improved the comments in tests.

[fnrizzi]

retest this please

[fnrizzi]

@thearusable please make sure you also post a draft PR in the wiki to update the documentation on the parallel_scan interface to reflect this PR

[fnrizzi]

see comment

[fnrizzi]

retest this please

[fnrizzi]

@thearusable this still have failures

for example:

4: /var/jenkins/workspace/Kokkos/core/unit_test/TestTeamScan.hpp:240: Failure
4: The difference between scan_ref and a_os(i) is 495, which exceeds abs_err, where
4: scan_ref evaluates to 561,
4: a_os(i) evaluates to 66, and
4: abs_err evaluates to 4.0531158447265625e-06.
4: /var/jenkins/workspace/Kokkos/core/unit_test/TestTeamScan.hpp:240: Failure
4: The difference between scan_ref and a_os(i) is 1521, where
4: scan_ref evaluates to 1711,
4: a_os(i) evaluates to 190.
4: The abs_error parameter abs_err evaluates to 1.3100631690576847e-14 which is smaller than the minimum distance between doubles for numbers of this magnitude which is 2.8421709430404007e-14, thus making this EXPECT_NEAR check equivalent to EXPECT_EQUAL. Consider using EXPECT_DOUBLE_EQ instead.
4: /var/jenkins/workspace/Kokkos/core/unit_test/TestTeamScan.hpp:240: Failure
4: The difference between scan_ref and a_os(i) is 1849, which exceeds abs_err, where
4: scan_ref evaluates to 2080,
4: a_os(i) evaluates to 231, and
4: abs_err evaluates to 7.7486038208007812e-06.
4: /var/jenkins/workspace/Kokkos/core/unit_test/TestTeamScan.hpp:240: Failure
4: The difference between scan_ref and a_os(i) is 61009, where
4: scan_ref evaluates to 68635,
4: a_os(i) evaluates to 7626.
4: The abs_error parameter abs_err evaluates to 8.2378548427186615e-14 which is smaller than the minimum distance between doubles for numbers of this magnitude which is 9.0949470177292824e-13, thus making this EXPECT_NEAR check equivalent to EXPECT_EQUAL. Consider using EXPECT_DOUBLE_EQ instead.
4: /var/jenkins/workspace/Kokkos/core/unit_test/TestTeamScan.hpp:238: Failure
4: Expected equality of these values:
4:   scan_ref
4:     Which is: 486591
4:   a_os(i)
4:     Which is: 53956
4: /var/jenkins/workspace/Kokkos/core/unit_test/TestTeamScan.hpp:240: Failure
4: The difference between scan_ref and a_os(i) is 763439, where
4: scan_ref evaluates to 858705,
4: a_os(i) evaluates to 95266.
4: The abs_error parameter abs_err evaluates to 2.9110047705671604e-13 which is smaller than the minimum distance between doubles for numbers of this magnitude which is 1.4551915228366852e-11, thus making this EXPECT_NEAR check equivalent to EXPECT_EQUAL. Consider using EXPECT_DOUBLE_EQ instead.
4: [  FAILED  ] openmp.team_scan_ret_val (1001 ms)

[masterleinad]

Please rebase on top of develop to fix some CI issues.

[thearusable]

@thearusable this still have failures

for example:

4: /var/jenkins/workspace/Kokkos/core/unit_test/TestTeamScan.hpp:240: Failure
4: The difference between scan_ref and a_os(i) is 495, which exceeds abs_err, where
4: scan_ref evaluates to 561,
4: a_os(i) evaluates to 66, and
4: abs_err evaluates to 4.0531158447265625e-06.
4: /var/jenkins/workspace/Kokkos/core/unit_test/TestTeamScan.hpp:240: Failure
4: The difference between scan_ref and a_os(i) is 1521, where
4: scan_ref evaluates to 1711,
4: a_os(i) evaluates to 190.
4: The abs_error parameter abs_err evaluates to 1.3100631690576847e-14 which is smaller than the minimum distance between doubles for numbers of this magnitude which is 2.8421709430404007e-14, thus making this EXPECT_NEAR check equivalent to EXPECT_EQUAL. Consider using EXPECT_DOUBLE_EQ instead.
4: /var/jenkins/workspace/Kokkos/core/unit_test/TestTeamScan.hpp:240: Failure
4: The difference between scan_ref and a_os(i) is 1849, which exceeds abs_err, where
4: scan_ref evaluates to 2080,
4: a_os(i) evaluates to 231, and
4: abs_err evaluates to 7.7486038208007812e-06.
4: /var/jenkins/workspace/Kokkos/core/unit_test/TestTeamScan.hpp:240: Failure
4: The difference between scan_ref and a_os(i) is 61009, where
4: scan_ref evaluates to 68635,
4: a_os(i) evaluates to 7626.
4: The abs_error parameter abs_err evaluates to 8.2378548427186615e-14 which is smaller than the minimum distance between doubles for numbers of this magnitude which is 9.0949470177292824e-13, thus making this EXPECT_NEAR check equivalent to EXPECT_EQUAL. Consider using EXPECT_DOUBLE_EQ instead.
4: /var/jenkins/workspace/Kokkos/core/unit_test/TestTeamScan.hpp:238: Failure
4: Expected equality of these values:
4:   scan_ref
4:     Which is: 486591
4:   a_os(i)
4:     Which is: 53956
4: /var/jenkins/workspace/Kokkos/core/unit_test/TestTeamScan.hpp:240: Failure
4: The difference between scan_ref and a_os(i) is 763439, where
4: scan_ref evaluates to 858705,
4: a_os(i) evaluates to 95266.
4: The abs_error parameter abs_err evaluates to 2.9110047705671604e-13 which is smaller than the minimum distance between doubles for numbers of this magnitude which is 1.4551915228366852e-11, thus making this EXPECT_NEAR check equivalent to EXPECT_EQUAL. Consider using EXPECT_DOUBLE_EQ instead.
4: [  FAILED  ] openmp.team_scan_ret_val (1001 ms)

Ok, fixed

[thearusable]

Please rebase on top of develop to fix some CI issues.

Ok, rebased

[crtrott]

I am a bit concerned about NVHPC not having run, but will risk merging it anyway.