Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5635: CUDA: Add Overloads for parallel_scan with return value for TeamThreadRange #6301

Merged
merged 2 commits into from
Sep 19, 2023
Merged

#5635: CUDA: Add Overloads for parallel_scan with return value for TeamThreadRange #6301

merged 2 commits into from
Sep 19, 2023

Conversation

thearusable
Copy link
Contributor

@thearusable thearusable commented Jul 24, 2023 •
edited

Related to #5635

Depends on #6090 (Merged already)

@thearusable thearusable self-assigned this Jul 24, 2023
@thearusable thearusable requested a review from fnrizzi July 24, 2023 13:48
@thearusable
Copy link
Contributor Author

Changes for TeamThreadRange moved from #6235

@fnrizzi
Copy link
Contributor

fnrizzi commented Jul 25, 2023 •
edited

please explicitly state this PR has a hard dependency on #6090 since that has to be merged first because it has the test in it.
So this PR should only be merged after the other one was merged.

@thearusable thearusable mentioned this pull request Jul 25, 2023
Merged
@thearusable
Copy link
Contributor Author

please explicitly state this PR has a hard dependency on #6090 since that has to be merged first because it has the test in it.
So this PR should only be merged after the other one was merged.

I added links to dependent PRs. They are not technically hard dependent on each other because I copied the tests to each PR but indeed it would be better to merge them in particular order.

@thearusable thearusable force-pushed the 5635-cuda-parallel-scan-TeamThreadRange branch from a8d2aca to 2e9ce72 Compare July 31, 2023 19:07
@ajpowelsnl
Copy link
Contributor

@thearusable - Does this PR need to be retested? IOW, is the PR otherwise ready to be merged?

@thearusable
Copy link
Contributor Author

@ajpowelsnl - Yes, this PR is ready to be merged. Retest could be performed to have a fresh CI results but I don't expect any new failures.

@masterleinad
Copy link
Contributor

Retest this please.

@cz4rs cz4rs force-pushed the 5635-cuda-parallel-scan-TeamThreadRange branch from 2e9ce72 to 6d794df Compare September 14, 2023 11:53
@masterleinad masterleinad mentioned this pull request Sep 14, 2023
Closed
@cz4rs
Copy link
Contributor

cz4rs commented Sep 15, 2023

Freshly rebased and good to go. hpx failure is unrelated.

@cz4rs cz4rs mentioned this pull request Sep 19, 2023
Closed
@crtrott crtrott merged commit 6f9e50c into kokkos:develop Sep 19, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@crtrott crtrott crtrott approved these changes

@fnrizzi fnrizzi fnrizzi approved these changes

Assignees

@thearusable thearusable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@thearusable @fnrizzi @ajpowelsnl @masterleinad @cz4rs @crtrott