#5635: HIP: Add Overloads for parallel_scan with return value for ThreadVectorRange #6242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thearusable
force-pushed
the
5635-hip-parallel-scan-with-value
branch
from
c0e6aa2
to
6ad0843
Compare
thearusable
changed the title
masterleinad
requested changes
Jul 7, 2023
thearusable
force-pushed
the
5635-hip-parallel-scan-with-value
branch
from
6ad0843
to
264acc6
Compare
thearusable
changed the title
I created the PRs as a chain which should be merged in particular order. This one is the last one currently created so it contains the changes from other ones. There will be at least two more PRs created. Edit: I added numeration in PR names to make that more clear. |
thearusable
force-pushed
the
5635-hip-parallel-scan-with-value
branch
from
264acc6
to
e933957
Compare
thearusable
force-pushed
the
5635-hip-parallel-scan-with-value
branch
from
e933957
to
cdb0e1f
Compare
thearusable
changed the title
This was referenced Jul 24, 2023
|
Marking as draft since dependencies have not been merged. |
Closed
masterleinad
force-pushed
the
5635-hip-parallel-scan-with-value
branch
2 times, most recently
from
b4feed9
to
f8ecd2f
Compare
cz4rs
force-pushed
the
5635-hip-parallel-scan-with-value
branch
from
f8ecd2f
to
6c6a26a
Compare
masterleinad
approved these changes
Sep 27, 2023
cz4rs
reviewed
Sep 27, 2023
Comment on lines
+800
to
+801
| if (i - 1 < loop_boundaries.end && threadIdx.x > 0) | ||
| closure(i - 1, val, false); |
There was a problem hiding this comment.
See the discussion #6235 (comment) for a similar fix in CUDA backend.
fnrizzi
approved these changes
Sep 28, 2023
|
gcc timed out , rest passes |
Rombur
reviewed
Oct 2, 2023
| @@ -1016,7 +1016,7 @@ struct checkScan { | |||
| }; | |||
| } // namespace VectorScanReducer | |||
|
|
|||
| #if !(defined(KOKKOS_IMPL_CUDA_CLANG_WORKAROUND) || defined(KOKKOS_ENABLE_HIP)) | |||
| #if !defined(KOKKOS_IMPL_CUDA_CLANG_WORKAROUND) | |||
There was a problem hiding this comment.
If it works for HIP and CUDA nvcc, there is a high probability that it also works for CUDA clang. Not for this PR but I think it's worth to check if the still need this condition.
Rombur
approved these changes
Oct 2, 2023
crtrott
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5635 #6453
Depends on #6235(merged)