Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5635: HIP: Add Overloads for parallel_scan with return value for TeamThreadRange #6302

Conversation

thearusable
Copy link
Contributor

@thearusable thearusable commented Jul 24, 2023

Related to #5635 #6453

Depends on #6301

@thearusable thearusable requested a review from fnrizzi July 24, 2023 14:16
@thearusable thearusable self-assigned this Jul 24, 2023
@thearusable
Copy link
Contributor Author

Changes for TeamThreadRange moved from #6242

@masterleinad
Copy link
Contributor

Marking as draft since dependencies have not been merged.

@cz4rs cz4rs force-pushed the 5635-hip-parallel-scan-with-value-TeamThreadRange branch from e215358 to 0915cf2 Compare September 20, 2023 11:32
@cz4rs
Copy link
Contributor

cz4rs commented Sep 21, 2023

Retest this please.

@cz4rs cz4rs marked this pull request as ready for review September 21, 2023 14:18
@cz4rs
Copy link
Contributor

cz4rs commented Sep 23, 2023

hpx failure is unrelated.

@dalg24
Copy link
Member

dalg24 commented Sep 26, 2023

Seeing one more of these openmptarget (clearly unrelated) failures

4: [ RUN      ] openmptarget.partitioning_by_vector
4: /var/jenkins/workspace/Kokkos/core/unit_test/TestExecSpacePartitioning.hpp:100: Failure
4: Expected equality of these values:
4:   sum1
4:     Which is: 7642095
4:   sum2
4:     Which is: 0
4: [  FAILED  ] openmptarget.partitioning_by_vector (0 ms)

The HIP-ROCm-5.2 build passed and I am willing to ignore the HIP-ROCm-5.6-C++20 timeout

@dalg24 dalg24 merged commit 1675997 into kokkos:develop Sep 26, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants