#5635: Serial/OpenMP: Parallel_scan with return value for ThreadVectorRange #6292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thearusable
force-pushed
the
5635-serial-parallel-scan-part-2
branch
from
187aa83
to
55f61a0
Compare
masterleinad
approved these changes
Jul 18, 2023
thearusable
force-pushed
the
5635-serial-parallel-scan-part-2
branch
from
55f61a0
to
afbbdcc
Compare
fnrizzi
approved these changes
Sep 5, 2023
dalg24
reviewed
Sep 5, 2023
Comment on lines
+610
to
+614
| #if defined(KOKKOS_ENABLE_SERIAL) || defined(KOKKOS_ENABLE_OPENMP) | ||
| #if !defined(KOKKOS_ENABLE_CUDA) && !defined(KOKKOS_ENABLE_HIP) && \ | ||
| !defined(KOKKOS_ENABLE_OPENACC) && !defined(KOKKOS_ENABLE_SYCL) && \ | ||
| !defined(KOKKOS_ENABLE_THREADS) && !defined(KOKKOS_ENABLE_OPENMPTARGET) && \ | ||
| !defined(KOKKOS_ENABLE_HPX) |
There was a problem hiding this comment.
Why are we not testing if for instance OpenMP+CUDA is enabled?
We can easily do something like
#ifdef KOKKOS_ENABLE_OPENMP
if constexpr (std::is_same_v<TEST_EXECSPACE, OpenMP>)
#endif
#ifdef KOKKOS_ENABLE_SERIAL
if constexpr (std::is_same_v<TEST_EXECSPACE, Serial>)
#endif
ASSERT_TRUE((TestTeamVector::Test<TEST_EXECSPACE>(12)));
There was a problem hiding this comment.
I think all the PRs are ready to introduce this for all backends? So it doesn't seem to matter too much?
dalg24
reviewed
Sep 5, 2023
Comment on lines
+638
to
+654
| [&](int i, Scalar &val, bool final) { | ||
| val += i; | ||
|
|
||
| if (final) { | ||
| Scalar test = 0; | ||
| for (int k = 0; k <= i; k++) test += k; | ||
| return_values(team.league_rank(), team.team_rank()) = test; | ||
|
|
||
| if (test != val) { | ||
| Kokkos::printf("FAILED vector_par_scan %i %i %lf %lf\n", | ||
| team.league_rank(), team.team_rank(), | ||
| static_cast<double>(test), | ||
| static_cast<double>(val)); | ||
|
|
||
| flag() = 1; | ||
| } | ||
| } |
There was a problem hiding this comment.
Mixing computation and checking the result is not good practice.
There was a problem hiding this comment.
btw this is following the similar approach used in the other tests here, so if you want to change the overall approach maybe we can do that in a separate PR?
crtrott
approved these changes
Sep 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5635