Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1673: matrix_frob_norm: incomplete spec #143

Closed
fnrizzi opened this issue Jan 17, 2022 · 1 comment
Closed

P1673: matrix_frob_norm: incomplete spec #143

fnrizzi opened this issue Jan 17, 2022 · 1 comment

Comments

@fnrizzi
Copy link
Contributor

fnrizzi commented Jan 17, 2022 •
edited
Loading

it seems to me that this is missing two things:

  1. it does not say how to use init
  2. shouldn't it have: Preconditions: abs(A[0,0]) shall be convertible to T.?
@fnrizzi fnrizzi changed the title P1673: matrix_frob_norm: missing description of how init is used P1673: matrix_frob_norm: incomplete spec Jan 17, 2022
@mhoemmen
Copy link
Contributor

Thanks for pointing this out! I've expanded the description of matrix_frob_norm in P1673R7 (to be submitted tonight) to include these details.

mhoemmen pushed a commit to mhoemmen/cpp-proposals-pub that referenced this issue Apr 15, 2022
P1673: R7 revisions
230b930 
* Update author affiliations and e-mail addresses

* Update proposal references

* Fix typo observed here:
  kokkos/stdBLAS#158

* Add missing ExecutionPolicy overload of in-place
  triangular_matrix_vector_product; issue was observed here:
  kokkos/stdBLAS#150

* Fix mixed-up order of sum_of_squares_result aggregate
  initialization arguments in vector_norm2 note

* Fill in missing parts of matrix_frob_norm and
  vector_norm2 specification, addressing this issue:
  kokkos/stdBLAS#143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhoemmen @fnrizzi