Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: preserve volumes list on plugin restart #7

Closed
kolayne opened this issue May 19, 2023 · 0 comments · Fixed by #16
Closed

Feature: preserve volumes list on plugin restart #7

kolayne opened this issue May 19, 2023 · 0 comments · Fixed by #16
Labels
enhancement New feature or request

Comments

@kolayne
Copy link
Owner

kolayne commented May 19, 2023

No description provided.

@kolayne kolayne added the enhancement New feature or request label May 19, 2023
@kolayne kolayne mentioned this issue May 31, 2023
kolayne added a commit that referenced this issue May 31, 2023
Wrote a doc for which directories exist for volumes and how they are supposed to be managed. It will be used for storage implementation (#7)
kolayne added a commit that referenced this issue May 31, 2023
The plugin now determines the active mounts for a volume (not overlay) using the activemounts/ subdirectory corresponding to the volume. It resolves the race condition problem with parallel mounts/unmounts on the same volume.

Gets us closer to fixing #7! However, not there yet, as we are still using go's `map`, which is thread-unsafe.
kolayne added a commit that referenced this issue Jun 2, 2023
- Removed the `volumes` field of `Driver`, instead introduced the metadata.json per-volume internal file, which currently stores the base directory path and the volatility.
- Rewrote the methods that used the in-memory volume storage to use the filesystem instead.
- Renamed dotBaseDir to `dotRootDir` and turned it into a field of `Driver`.

Fixes #7.
As far as I can see, fixes #15!

The code is starting to get bulky, probably, restructuring is needed...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant