This repository has been archived by the owner on Dec 15, 2020. It is now read-only.
Remove -i flag from Go builds in the Makefile #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwass
approved these changes
Sep 25, 2020
There was a problem hiding this comment.
I took a look through the history to find where that flag was added (https://github.com/kolide/fleet/pull/197/files#diff-b67911656ef5d18c4ae36cb6741b7965R65) and can't see any indication that it was added for a specific reason.
I successfully tested a local build on macOS as well as a cross-compile for the Docker container. Both seemed to generate working binaries.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-i(install) flag is not necessary and caused issues with building in some scenarios.Fixes #2287