Add option to include stderr with stdout for execparser #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
approved these changes
Apr 13, 2023
| @@ -20,7 +20,7 @@ import ( | |||
| // 3. It moves the stderr into the return error, if needed. | |||
| // | |||
| // This is not suitable for high performance work -- it allocates new buffers each time. | |||
| func Exec(ctx context.Context, logger log.Logger, timeoutSeconds int, possibleBins []string, args []string) ([]byte, error) { | |||
| func Exec(ctx context.Context, logger log.Logger, timeoutSeconds int, possibleBins []string, args []string, includeStderr bool) ([]byte, error) { | |||
There was a problem hiding this comment.
Arg list is unweildly, but this seems better than starting the work of moving to functional arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered that
softwareupdatewritesNo new software availableto stderr instead of stdout, meaning we were unable to actually determine whether the device is up-to-date in the kolide_softwareupdate and kolide_softwareupdate_scan tables. This PR adds an option to the execparser to include stderr in stdout; it accomplishes this the same way that exec'sCombinedOutputfunction works.