Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructures desktop directory to differentiate between runner and user components #1167

Merged

Conversation

James-Pickett
Copy link
Contributor

@James-Pickett James-Pickett commented Apr 28, 2023

old structure:

ee/desktop
├── assets
├── client
├── menu
├── notify
├── runner
│   └── server
└── server

new structure:

ee/desktop
├── runner
│   └── server
└── user
    ├── client
    ├── menu
    ├── notify
    └── server

@James-Pickett James-Pickett marked this pull request as ready for review April 28, 2023 18:44
Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@seejdev
Copy link
Contributor

seejdev commented Apr 29, 2023

Nice!

Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed structure seems okay. We still have runner/server and user/server, but this is hugely improved.

@James-Pickett James-Pickett merged commit 245bc12 into kolide:main May 1, 2023
@James-Pickett James-Pickett deleted the james/desktop-pkg-restructure branch May 1, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants