MSI User Interface #625
Merged
MSI User Interface #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
force-pushed
the
seph/msi-confirmation
branch
from
6054e82
to
ec046e7
Compare
|
This pull request introduces 1 alert when merging cc63b83 into 8743fe2 - view on LGTM.com new alerts:
|
blaedj
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
lgtm, leaning on the assumption that this has been tested by @FritzX6 and @terracatta as well.
Co-authored-by: blaedj <blaedj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic user interface to the MSI. This is based on wix's
WixUI_Minimal, but removes some of the screens we don't need. This is not currently exposed throughpackage-builderAn additional notable change is to the MSI's
ProductCode. This introduces a random factor, ensuring that each MSI has a uniqueProductCode. Which means that any MSI will be able to install over other versions. This is an unusual choice from an MSI perspective, but it fit with out minimal usage of it