Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for NX 19 #108

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

gcko
Copy link
Contributor

@gcko gcko commented May 22, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Configuration related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

This PR adds support for NX 19 (#106), while only updating packages using nx migrate latest

  • Updates to eslint, @swc/cli, typescript, etc, was done by the nx migration script.

Which package are you modifying?

  • @koliveira15/nx-sonarqube
  • docs-site

What is the current behavior?

Closes #106

What is the new behavior?

This PR allows for NX 19 support. No other new behavior.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

- Bump most of the dependencies to their latest
- Don't change tsquery, that requires refactoring
- Update eslint to latest 8.x branch. Don't upgrade to 9 (requires refactoring)
Copy link

nx-cloud bot commented May 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e1e7cf9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@gcko
Copy link
Contributor Author

gcko commented May 23, 2024

@koliveira15 this PR addresses your requests in the prior PR: #107 (comment)

@koliveira15
Copy link
Owner

@koliveira15 this PR addresses your requests in the prior PR: #107 (comment)

LGTM, thanks!

@koliveira15 koliveira15 merged commit 19b582f into koliveira15:main May 23, 2024
6 checks passed
@C0ZEN
Copy link
Contributor

C0ZEN commented May 28, 2024

@gcko @koliveira15 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Nx 19
3 participants