feat: add support for NX 19 #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump most of the dependencies to their latest - Don't change tsquery, that requires refactoring - Update eslint to latest 8.x branch. Don't upgrade to 9 (requires refactoring)
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0332e5f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
koliveira15
requested changes
May 21, 2024
|
Sure
Best,
Jared Scott
Founder | Variable
+1 (562) 302-8063
+886966463236
…________________________________
From: Kevin Oliveira ***@***.***>
Sent: Tuesday, May 21, 2024 9:25:00 PM
To: koliveira15/nx-sonarqube ***@***.***>
Cc: Jared Scott ***@***.***>; Mention ***@***.***>
Subject: Re: [koliveira15/nx-sonarqube] feat: add support for NX 19 (PR #107)
@koliveira15 requested changes on this pull request.
________________________________
On package.json<#107 (comment)>:
@gcko<https://github.com/gcko> Thanks for the contribution. I would prefer if PRs for Nx upgrades like this were only scoped to Nx migrations changes. Bumping other packages deserves their own issue & PR. Redo with just npx nx migrate latest changes and I will approve
—
Reply to this email directly, view it on GitHub<#107 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAD7NR5BTTZIFSKPXQHQ2ETZDNDKZAVCNFSM6AAAAABIBKCN4CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRYGY2DEMJSGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
This PR adds support for NX 19 (#106), while updating most package dependencies to their latest
Which package are you modifying?
What is the current behavior?
Closes #106
What is the new behavior?
This PR allows for NX 19 support. No other new behavior.
Does this PR introduce a breaking change?
Other information