Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow running the tests with vitest #62

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

C0ZEN
Copy link
Contributor

@C0ZEN C0ZEN commented Nov 20, 2023

ℹ️ I suggest rebasing the 3 commits instead of squashing them to keep a clean history.

Closes #54

@C0ZEN
Copy link
Contributor Author

C0ZEN commented Nov 21, 2023

@koliveira15 👀

Copy link

@Bullfrog1234 Bullfrog1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that this is not a coverage at a app level but at each project level. My code comments show where that would need to change.

Will do an update if not fixed in 4 weeks as I am going to be not able to do until I take Christmas leave.

Overall I like the idea just not the complete implementation. @C0ZEN thanks for the idea.

README.md Outdated Show resolved Hide resolved
packages/nx-sonarqube/src/executors/scan/utils/utils.ts Outdated Show resolved Hide resolved
packages/nx-sonarqube/src/executors/scan/utils/utils.ts Outdated Show resolved Hide resolved
packages/nx-sonarqube/src/executors/scan/schema.d.ts Outdated Show resolved Hide resolved
packages/nx-sonarqube/src/executors/scan/schema.json Outdated Show resolved Hide resolved
@C0ZEN C0ZEN changed the title feat: add new input "executor" to allow running the tests with vitest feat: allow running the tests with vitest Nov 23, 2023
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Nov 23, 2023

I made the suggested by @Bullfrog1234 regarding how to handle each libs and apps for the coverage configuration.
It's easier, transparent for the consumers and for sustainable in the future now.

The executor used will be detected, and based on this, the coverage directory path will change to make this project compatible with a runner using vite.

Copy link

@Bullfrog1234 Bullfrog1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and my opinion can be merged.

@koliveira15 over to you to merge.

.gitignore Outdated Show resolved Hide resolved
.tool-versions Outdated Show resolved Hide resolved
migrations.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
Copy link

nx-cloud bot commented Nov 29, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7c738de. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@C0ZEN C0ZEN force-pushed the feat/support-vitest branch 2 times, most recently from 8732bf1 to 40957e3 Compare November 29, 2023 17:12
The executor will be read to define what configuration is expected in order to read the right path for the coverage directory.
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Nov 29, 2023

@koliveira15 done

@C0ZEN
Copy link
Contributor Author

C0ZEN commented Nov 30, 2023

BTW, the nx-cloud agent seems not to be triggered again, the lint failure is obsolete, and the commit hash used is an old one.

@koliveira15
Copy link
Owner

BTW, the nx-cloud agent seems not to be triggered again, the lint failure is obsolete, and the commit hash used is an old one.

I believe that's because you're a first time contributor & using a fork. should be good now

@koliveira15 koliveira15 merged commit 77759b5 into koliveira15:main Nov 30, 2023
6 checks passed
@koliveira15
Copy link
Owner

@C0ZEN thank you very much for this contribution! ❤️ I plan on refactoring the utils.ts file into smaller, manageable chunks while also improving the architecture to easily allow more test runners in the future.

@C0ZEN C0ZEN deleted the feat/support-vitest branch November 30, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Vitest
3 participants