-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow running the tests with vitest #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that this is not a coverage at a app level but at each project level. My code comments show where that would need to change.
Will do an update if not fixed in 4 weeks as I am going to be not able to do until I take Christmas leave.
Overall I like the idea just not the complete implementation. @C0ZEN thanks for the idea.
f797c78
to
fc28299
Compare
fc28299
to
41b541c
Compare
I made the suggested by @Bullfrog1234 regarding how to handle each libs and apps for the coverage configuration. The executor used will be detected, and based on this, the coverage directory path will change to make this project compatible with a runner using vite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and my opinion can be merged.
@koliveira15 over to you to merge.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7c738de. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
8732bf1
to
40957e3
Compare
The executor will be read to define what configuration is expected in order to read the right path for the coverage directory.
40957e3
to
7c738de
Compare
@koliveira15 done |
BTW, the nx-cloud agent seems not to be triggered again, the lint failure is obsolete, and the commit hash used is an old one. |
I believe that's because you're a first time contributor & using a fork. should be good now |
@C0ZEN thank you very much for this contribution! ❤️ I plan on refactoring the utils.ts file into smaller, manageable chunks while also improving the architecture to easily allow more test runners in the future. |
ℹ️ I suggest rebasing the 3 commits instead of squashing them to keep a clean history.
Closes #54