Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action/preaction issue #1109

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Fix action/preaction issue #1109

merged 2 commits into from
Sep 22, 2022

Conversation

gausie
Copy link
Contributor

@gausie gausie commented Sep 22, 2022

This is mostly here for the failing test, though I have also added some band-aid fixes for matching preactions with actions where necessary.

@gausie gausie marked this pull request as ready for review September 22, 2022 10:38
@gausie gausie requested a review from a team as a code owner September 22, 2022 10:38
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #1109 (83395a8) into main (31385a0) will increase coverage by 0.03%.
The diff coverage is 13.04%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1109      +/-   ##
============================================
+ Coverage     30.00%   30.04%   +0.03%     
- Complexity    14568    14585      +17     
============================================
  Files          1037     1037              
  Lines        161261   161262       +1     
  Branches      35182    35180       -2     
============================================
+ Hits          48388    48448      +60     
+ Misses       104140   104064      -76     
- Partials       8733     8750      +17     
Impacted Files Coverage Δ
...urceforge/kolmafia/request/PandamoniumRequest.java 2.73% <0.00%> (+0.03%) ⬆️
...t/sourceforge/kolmafia/request/RichardRequest.java 21.42% <0.00%> (ø)
...ourceforge/kolmafia/request/CampgroundRequest.java 32.23% <28.57%> (-0.12%) ⬇️
...t/sourceforge/kolmafia/request/GenericRequest.java 30.04% <50.00%> (+0.02%) ⬆️
...ourceforge/kolmafia/request/ClanLoungeRequest.java 25.56% <60.00%> (+4.50%) ⬆️
...ourceforge/kolmafia/request/ClanRumpusRequest.java 14.08% <0.00%> (+2.58%) ⬆️
...sourceforge/kolmafia/textui/langserver/Script.java 85.10% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31385a0...83395a8. Read the comment docs.

@Veracity0
Copy link
Contributor

Nice.

I think this tells me that when I do the Azazel quest next run, I need to get some DEBUG logs for when I interact with the various NPCs. :)

@gausie gausie merged commit aa34e76 into main Sep 22, 2022
@gausie gausie deleted the fix-action-preaction branch September 22, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants