Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache encoded pref values during tests. #1288

Merged
merged 2 commits into from Nov 15, 2022
Merged

Conversation

phulin
Copy link
Contributor

@phulin phulin commented Nov 15, 2022

This should reverse the performance penalty with tests.

@phulin phulin requested a review from a team as a code owner November 15, 2022 00:56
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #1288 (bba03ab) into main (9a91981) will increase coverage by 0.30%.
The diff coverage is 90.90%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1288      +/-   ##
============================================
+ Coverage     32.34%   32.64%   +0.30%     
- Complexity    16061    16221     +160     
============================================
  Files          1043     1043              
  Lines        162635   162639       +4     
  Branches      35303    35303              
============================================
+ Hits          52602    53101     +499     
+ Misses       100822   100227     -595     
- Partials       9211     9311     +100     
Impacted Files Coverage Δ
.../sourceforge/kolmafia/preferences/Preferences.java 84.89% <90.90%> (+0.13%) ⬆️
.../sourceforge/kolmafia/request/StandardRequest.java 78.37% <0.00%> (-2.71%) ⬇️
...sourceforge/kolmafia/textui/langserver/Script.java 80.85% <0.00%> (ø)
...eforge/kolmafia/swingui/panel/GearChangePanel.java 58.87% <0.00%> (+0.13%) ⬆️
src/net/sourceforge/kolmafia/KoLmafiaCLI.java 69.86% <0.00%> (+0.15%) ⬆️
src/net/sourceforge/kolmafia/StaticEntity.java 22.06% <0.00%> (+0.27%) ⬆️
...et/sourceforge/kolmafia/textui/RuntimeLibrary.java 36.02% <0.00%> (+0.30%) ⬆️
src/net/sourceforge/kolmafia/RequestLogger.java 28.76% <0.00%> (+0.41%) ⬆️
...sourceforge/kolmafia/persistence/TCRSDatabase.java 54.81% <0.00%> (+0.42%) ⬆️
...net/sourceforge/kolmafia/textui/DataFileCache.java 43.39% <0.00%> (+0.94%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a91981...bba03ab. Read the comment docs.

@gausie gausie enabled auto-merge (squash) November 15, 2022 14:11
@gausie gausie merged commit ea23553 into kolmafia:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants