Don't cache encoded pref values during tests. (#1288)

Co-authored-by: Samuel Gaus <sam@gaus.co.uk>

src/net/sourceforge/kolmafia/preferences/Preferences.java

@@ -687,6 +687,10 @@ private static String encodeProperty(String name, String value) {
     return buffer.toString();
   }
 
+  private static boolean mustTrackEncodedValues() {
+    return Preferences.getBoolean("saveSettingsOnSet") && Preferences.saveSettingsToFile;
+  }
+
   private static void reinitializeEncodedValuesOn(
       Map<String, Object> valuesMap, Map<String, byte[]> encodedMap) {
     for (Entry<String, Object> entry : valuesMap.entrySet()) {
@@ -699,6 +703,11 @@ private static void reinitializeEncodedValuesOn(
 
   /** Recompute all cached encoded values from the value maps. */
   private static void reinitializeEncodedValues() {
+    // No need to do this at all if not writing to a file.
+    if (!Preferences.saveSettingsToFile) {
+      return;
+    }
+
     Preferences.reinitializeEncodedValuesOn(
         Preferences.globalValues, Preferences.globalEncodedValues);
     Preferences.reinitializeEncodedValuesOn(Preferences.userValues, Preferences.userEncodedValues);
@@ -788,26 +797,26 @@ public static String getDefault(final String name) {
   }
 
   public static void removeProperty(final String name, final boolean global) {
-    boolean saveSettingsOnSet = getBoolean("saveSettingsOnSet");
+    boolean trackEncoded = Preferences.mustTrackEncodedValues();
     // Remove only properties which do not have defaults
     if (global) {
       if (!Preferences.globalNames.containsKey(name)) {
         // We are changing the structure of the map.
         // globalValues is a synchronized map.
 
         Preferences.globalValues.remove(name);
-        if (saveSettingsOnSet) Preferences.globalEncodedValues.remove(name);
+        if (trackEncoded) Preferences.globalEncodedValues.remove(name);
       }
     } else {
       if (!Preferences.userNames.containsKey(name)) {
         // We are changing the structure of the map.
         // userValues is a synchronized map.
 
         Preferences.userValues.remove(name);
-        if (saveSettingsOnSet) Preferences.userEncodedValues.remove(name);
+        if (trackEncoded) Preferences.userEncodedValues.remove(name);
       }
     }
-    Preferences.maybeSaveToFileAfterUpdating(saveSettingsOnSet, name);
+    Preferences.maybeSaveToFileAfterUpdating(trackEncoded, name);
     PreferenceListenerRegistry.firePreferenceChanged(name);
   }
 
@@ -1104,17 +1113,18 @@ private static void setObject(
       }
     }
 
-    boolean saveSettings = Preferences.getBoolean("saveSettingsOnSet");
+    boolean trackEncoded = Preferences.mustTrackEncodedValues();
 
     // We stop tracking encoded values when saveSettingsOnSet is off. When it is turned back on,
     // many encoded values will be out of date, and we don't know which ones, so we have to
     // recompute all of them.
     if (name == "saveSettingsOnSet" && (boolean) object) {
       Preferences.reinitializeEncodedValues();
+      trackEncoded |= Preferences.saveSettingsToFile;
     }
 
-    Preferences.put(user, name, object, saveSettings);
-    Preferences.maybeSaveToFileAfterUpdating(saveSettings, name);
+    Preferences.put(user, name, object, trackEncoded);
+    Preferences.maybeSaveToFileAfterUpdating(trackEncoded, name);
 
     PreferenceListenerRegistry.firePreferenceChanged(name);