Treat Holidays and their associated modifiers as Events and include in modifiers.txt #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gausie
commented
Sep 13, 2023
•
gausie
commented
- Express holiday and event modifiers in modifiers.txt
- Allow calculation of multiple holidays on one day
- Add Labor Day Eve (not exposed to the user)
- Expose joint events as a list so we can check for the presence of one holiday if necessary
- Refactor some functions to do less string comparison
- Add tests
|
I'm going to let the CI show me where I should add test coverage. |
… refactor some functions to do less string comparison, add tests
gausie
force-pushed
the
holidays-as-events
branch
from
987b583
to
4a09c9e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1958 +/- ##
============================================
+ Coverage 36.57% 36.60% +0.03%
- Complexity 18978 18996 +18
============================================
Files 1087 1087
Lines 166925 166889 -36
Branches 35458 35439 -19
============================================
+ Hits 61061 61098 +37
+ Misses 95922 95854 -68
+ Partials 9942 9937 -5
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
midgleyc
reviewed
Sep 13, 2023
midgleyc
reviewed
Sep 13, 2023
midgleyc
reviewed
Sep 13, 2023
midgleyc
reviewed
Sep 13, 2023
midgleyc
reviewed
Sep 13, 2023
test/net/sourceforge/kolmafia/request/MoonPhaseRequestTest.java
Outdated
Show resolved
Hide resolved
midgleyc
reviewed
Sep 13, 2023
test/net/sourceforge/kolmafia/textui/command/SetHolidayCommandTest.java
Outdated
Show resolved
Hide resolved
…ppen during testing
…Also update modifier writer to include new events? Weird one
midgleyc
requested changes
Sep 14, 2023
| Event Muscle Day Experience Percent (Muscle): [25*interact()] | ||
| Event Mysticality Day Experience Percent (Mysticality): [25*interact()] | ||
| Event Festival of Jarlsberg Mana Cost: -3 | ||
| Event Labór Day Eve Adventures: +10 |
There was a problem hiding this comment.
Does Labor day work in run? I can't recall.
There was a problem hiding this comment.
The wiki suggests it does, so I did this. But I'll ask on Discord.
There was a problem hiding this comment.
Yeah people think that it does work in run
midgleyc
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.