Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numeric_modifier("adventures") lists Labor day adventures. Remove double count. #225

Merged
merged 1 commit into from
May 17, 2024

Conversation

Malibu-Stacey
Copy link
Member

image

Gausie added Labór Day Eve to mafia a while ago (see kolmafia/kolmafia#1958).

@Malibu-Stacey Malibu-Stacey added the bug Something isn't working label Apr 19, 2024
@Malibu-Stacey Malibu-Stacey requested review from a team April 19, 2024 18:51
@Malibu-Stacey Malibu-Stacey self-assigned this Apr 19, 2024
@gausie
Copy link

gausie commented Apr 20, 2024

Do we need getHolidaysTomorrow() anymore?

@Malibu-Stacey
Copy link
Member Author

Do we need getHolidaysTomorrow() anymore?

IIRC it uses that to warn about stuff like "Save adventures for Halloween tomorrow".

Copy link
Member

@docrostov docrostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this should've been updated a while back when the mafia devs updated holiday tracking; good catch, thanks malibu!

@docrostov docrostov merged commit 54fdbc2 into main May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants