Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store everfull dart perks #2232

Merged
merged 1 commit into from Mar 10, 2024
Merged

Conversation

midgleyc
Copy link
Member

Store everfull dart perks in a preference (comma-separated). Update on logon / post-dart perk pick / ascension.

Some script authors, particularly TourGuide, have requested this to save on server hits.

@midgleyc midgleyc requested a review from a team as a code owner March 10, 2024 12:13
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 37.35%. Comparing base (d8651b3) to head (dace8bf).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2232   +/-   ##
=========================================
  Coverage     37.35%   37.35%           
- Complexity    19762    19765    +3     
=========================================
  Files          1109     1109           
  Lines        169430   169451   +21     
  Branches      35794    35795    +1     
=========================================
+ Hits          63286    63299   +13     
- Misses        96115    96122    +7     
- Partials      10029    10030    +1     
Files Coverage Δ
src/net/sourceforge/kolmafia/KoLmafia.java 38.26% <100.00%> (+0.07%) ⬆️
.../net/sourceforge/kolmafia/objectpool/ItemPool.java 14.28% <ø> (ø)
.../sourceforge/kolmafia/preferences/Preferences.java 83.54% <ø> (ø)
...et/sourceforge/kolmafia/session/ChoiceControl.java 10.89% <0.00%> (-0.01%) ⬇️
...urceforge/kolmafia/session/ResponseTextParser.java 40.32% <0.00%> (-0.09%) ⬇️
...sourceforge/kolmafia/persistence/ItemDatabase.java 49.32% <83.33%> (+0.39%) ⬆️
...sourceforge/kolmafia/session/InventoryManager.java 41.63% <40.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8651b3...dace8bf. Read the comment docs.

@midgleyc midgleyc merged commit 8c743a5 into kolmafia:main Mar 10, 2024
5 checks passed
@midgleyc midgleyc deleted the everfull-perks branch March 10, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants