feat: store everfull dart perks

src/data/defaults.txt

@@ -654,6 +654,7 @@ user	essenceOfAnnoyanceCost	5000
 user	essenceOfBearAvailable	true
 user	essenceOfBearCost	1000
 user	EVEDirections	LLRLR0
+user	everfullDartPerks
 user	expressCardUsed	false
 user	extraCosmeticModifiers	
 user	extraRolloverAdventures	0

src/net/sourceforge/kolmafia/KoLmafia.java

@@ -890,6 +890,9 @@ private static void refreshSessionData() {
     // Items that conditionally grant skills
     InventoryManager.checkSkillGrantingEquipment();
 
+    // check dart perks on logon
+    InventoryManager.checkDartPerks();
+
     // Check Horsery if we haven't today
     if (Preferences.getBoolean("horseryAvailable")
         && Preferences.getString("_horseryCrazyMox").length() == 0) {

src/net/sourceforge/kolmafia/objectpool/ItemPool.java

@@ -3742,6 +3742,7 @@ public class ItemPool {
   public static final int QUICK_RELEASE_UTILITY_BELT = 11557;
   public static final int MOTION_SENSOR = 11558;
   public static final int FOCUSED_MAGNETRON_PISTOL = 11559;
+  public static final int EVERFULL_DART_HOLSTER = 11561;
   public static final int RESEARCH_FRAGMENT = 11562;
 
   private ItemPool() {}

src/net/sourceforge/kolmafia/persistence/ItemDatabase.java

@@ -16,6 +16,7 @@
 import java.util.TreeMap;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
+import java.util.stream.Collectors;
 import javax.swing.ImageIcon;
 import net.java.dev.spellcast.utilities.JComponentUtilities;
 import net.sourceforge.kolmafia.AdventureResult;
@@ -50,8 +51,12 @@
 import net.sourceforge.kolmafia.session.ElVibratoManager.Punchcard;
 import net.sourceforge.kolmafia.session.EquipmentManager;
 import net.sourceforge.kolmafia.utilities.FileUtilities;
+import net.sourceforge.kolmafia.utilities.HTMLParserUtils;
 import net.sourceforge.kolmafia.utilities.LogStream;
 import net.sourceforge.kolmafia.utilities.StringUtilities;
+import org.htmlcleaner.HtmlCleaner;
+import org.htmlcleaner.TagNode;
+import org.htmlcleaner.XPatherException;
 import org.json.JSONException;
 import org.json.JSONObject;
 
@@ -2345,6 +2350,27 @@
     }
   }
 
+  public static void parseDartPerks(final String desc) {
+    if (!desc.contains("Active Perks")) {
+      Preferences.setString("everfullDartPerks", "");
+    } else {
+      HtmlCleaner cleaner = HTMLParserUtils.configureDefaultParser();
+      TagNode doc = cleaner.clean(desc);
+      String xpath = "//ul/li/text()";
+
+      Object[] result;
+      try {
+        result = doc.evaluateXPath(xpath);
+      } catch (XPatherException ex) {
+        // do nothing
+        return;
+      }
+
+      var perks = Arrays.stream(result).map(Object::toString).collect(Collectors.joining(","));
+      Preferences.setString("everfullDartPerks", perks);
+    }
+  }
+
   public static boolean unusableInBeecore(final int itemId) {
     return switch (itemId) {
       case

src/net/sourceforge/kolmafia/preferences/Preferences.java

@@ -274,6 +274,7 @@ public class Preferences {
         "ensorceleeLevel",
         "entauntaunedColdRes",
         "envyfishMonster",
+        "everfullDartPerks",
         "falloutShelterChronoUsed",
         "falloutShelterCoolingTankUsed",
         "familiarSweat",

src/net/sourceforge/kolmafia/session/ChoiceControl.java

@@ -6753,6 +6753,11 @@
         // Moonlighting
         handleAfterAvatar(ChoiceManager.lastDecision);
         break;
+
+      case 1525:
+        // Dart Perks
+        InventoryManager.checkDartPerks();
+        break;
     }
   }
 

src/net/sourceforge/kolmafia/session/InventoryManager.java

@@ -1822,6 +1822,15 @@
     checkItemDescription(id);
   }
 
+  public static void checkDartPerks() {
+    var dartHolster = ItemPool.EVERFULL_DART_HOLSTER;
+    if (!InventoryManager.equippedOrInInventory(ItemPool.get(dartHolster, 1))) {
+      return;
+    }
+
+    checkItemDescription(dartHolster);
+  }
+
   private static final AdventureResult GOLDEN_MR_ACCESSORY =
       ItemPool.get(ItemPool.GOLDEN_MR_ACCESSORY, 1);
 

src/net/sourceforge/kolmafia/session/ResponseTextParser.java

@@ -435,6 +435,7 @@
                   .parsePowerfulGlove(responseText);
               case ItemPool.RING -> ItemDatabase.parseRing(responseText);
               case ItemPool.LATTE_MUG -> LatteRequest.parseDescription(responseText);
+              case ItemPool.EVERFULL_DART_HOLSTER -> ItemDatabase.parseDartPerks(responseText);
               default -> changesFromTimeToTime = false;
             }
 

test/net/sourceforge/kolmafia/persistence/ItemDatabaseTest.java

@@ -1,13 +1,20 @@
 package net.sourceforge.kolmafia.persistence;
 
+import static internal.helpers.Networking.html;
+import static internal.helpers.Player.withProperty;
+import static internal.matchers.Preference.hasStringValue;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.emptyString;
+import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.is;
 
 import java.util.EnumSet;
+import net.sourceforge.kolmafia.KoLCharacter;
 import net.sourceforge.kolmafia.KoLConstants.ConsumptionType;
 import net.sourceforge.kolmafia.objectpool.ItemPool;
 import net.sourceforge.kolmafia.persistence.ItemDatabase.Attribute;
+import net.sourceforge.kolmafia.preferences.Preferences;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 
@@ -94,4 +101,39 @@ public void checksItemFlags() {
     assertThat(ItemDatabase.isPasteable(ItemPool.SEAL_CLUB), is(true));
     assertThat(ItemDatabase.isChocolateItem(ItemPool.SEAL_CLUB), is(false));
   }
+
+  @Nested
+  class EverfullDartPerks {
+    @BeforeEach
+    public void beforeEach() {
+      KoLCharacter.reset("EverfullDartPerks");
+      Preferences.reset("EverfullDartPerks");
+    }
+
+    @Test
+    public void parsesNoPerks() {
+      var cleanups = withProperty("everfullDartPerks", "Throw a second dart quickly");
+
+      try (cleanups) {
+        var response = html("request/test_desc_item_everfull_dart_holster_no_perks.html");
+        ItemDatabase.parseDartPerks(response);
+        assertThat("everfullDartPerks", hasStringValue(equalTo("")));
+      }
+    }
+
+    @Test
+    public void parsesPerks() {
+      var cleanups = withProperty("everfullDartPerks", "");
+
+      try (cleanups) {
+        var response = html("request/test_desc_item_everfull_dart_holster_perks.html");
+        ItemDatabase.parseDartPerks(response);
+        assertThat(
+            "everfullDartPerks",
+            hasStringValue(
+                equalTo(
+                    "Deal 25-50% more damage,You are less impressed by bullseyes,25% Better bullseye targeting,Extra stats from stats targets,Butt awareness,Add Sleaze Damage")));
+      }
+    }
+  }
 }

test/root/request/test_desc_item_everfull_dart_holster_no_perks.html

@@ -0,0 +1 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN""http://www.w3.org/TR/html4/loose.dtd"><html><head><title>Item Description</title><link rel="stylesheet" type="text/css" href="https://d2uyhvukfffg5a.cloudfront.net/styles.20230117d.css"><style>a.hand {cursor: pointer;}</style><script language=Javascript src="https://d2uyhvukfffg5a.cloudfront.net/scripts/keybinds.min.2.js"></script><script language=Javascript src="https://d2uyhvukfffg5a.cloudfront.net/scripts/window.20111231.js"></script></head><body><div id="description" class=small><center><img  src="https://d2uyhvukfffg5a.cloudfront.net/itemimages/dartholster.gif" height=30 width=30 alt="dartholster"><br><b>Everfull Dart Holster</b></center><p><blockquote>This is your trusty dart holster. Put it on your hip. Draw a dart, throw it.  Draw a dart.  Throw it.  Draw a dart throw it. Draw a dart, throw it.  Draw a dart. Throw it.   You get the idea.<!-- itemid: 11561 --><br><br>Type: <b>accessory</b><Br>Cannot be traded or discarded<p><center><b><font color=blue>Combat Initiative +50%<br>All Attributes +10%<br>Throw Darts in Battle</font></b></center><br><b>NOTE:</b> You may not equip more than one of these at a time.</blockquote><script type="text/javascript"><!--var resizetries = 0;var fsckinresize;setTimeout(fsckinresize = function ()  {var desch = document.getElementById('description').offsetHeight;if (desch < 100 && resizetries < 5) {setTimeout(fsckinresize, 100);resizetries++;}if (desch < 100) desch = 200;//alert('resizing on try #' + resizetries);if (self.resizeTo && window.outerHeight) {self.resizeTo(400, desch + (window.outerHeight - window.innerHeight) + 50);}else if (self.resizeTo ) { self.resizeTo(400, desch+130); }else { window.innerHeight = newh; }}, 100);//--></script></div></body></html>

test/root/request/test_desc_item_everfull_dart_holster_perks.html

@@ -0,0 +1,38 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
+	"http://www.w3.org/TR/html4/loose.dtd">
+<html><head>
+<title>Item Description</title>
+<link rel="stylesheet" type="text/css" href="https://d2uyhvukfffg5a.cloudfront.net/styles.20230117d.css">
+<style>
+a.hand {
+	cursor: pointer;
+}
+</style>
+<script language=Javascript src="https://d2uyhvukfffg5a.cloudfront.net/scripts/keybinds.min.2.js"></script>
+<script language=Javascript src="https://d2uyhvukfffg5a.cloudfront.net/scripts/window.20111231.js"></script>
+</head>
+<body>
+
+<div id="description" class=small><center><img  src="https://d2uyhvukfffg5a.cloudfront.net/itemimages/dartholster.gif" height=30 width=30 alt="dartholster"><br><b>Everfull Dart Holster</b></center><p><blockquote>This is your trusty dart holster. Put it on your hip. Draw a dart, throw it.  Draw a dart.  Throw it.  Draw a dart throw it. Draw a dart, throw it.  Draw a dart. Throw it.   You get the idea.<p><b>Active Perks</b><ul><li>Deal 25-50% more damage<li>You are less impressed by bullseyes<li>25% Better bullseye targeting<li>Extra stats from stats targets<li>Butt awareness<li>Add Sleaze Damage</ul><!-- itemid: 11561 --><br><br>Type: <b>accessory</b><Br>Cannot be traded or discarded<p><center><b><font color=blue>Combat Initiative +50%<br>All Attributes +10%<br>Throw Darts in Battle</font></b></center><br><b>NOTE:</b> You may not equip more than one of these at a time.</blockquote><script type="text/javascript">
+<!--
+var resizetries = 0;
+var fsckinresize;
+setTimeout(fsckinresize = function ()  {
+	var desch = document.getElementById('description').offsetHeight;
+	if (desch < 100 && resizetries < 5) {
+		setTimeout(fsckinresize, 100);
+		resizetries++;
+	}
+	if (desch < 100) desch = 200; 
+	//alert('resizing on try #' + resizetries);
+	if (self.resizeTo && window.outerHeight) { 
+		self.resizeTo(400, desch + (window.outerHeight - window.innerHeight) + 50); 
+	}
+	else if (self.resizeTo ) { self.resizeTo(400, desch+130); }
+	else { window.innerHeight = newh; }
+}, 100);
+//-->
+</script>
+</div>
+</body>
+</html>