Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disambiguate monster names in combat lover's locket #2234

Merged
merged 2 commits into from Mar 12, 2024
Merged

Conversation

Veracity0
Copy link
Contributor

No description provided.

@Veracity0 Veracity0 requested a review from a team as a code owner March 12, 2024 16:25
midgleyc
midgleyc previously approved these changes Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 37.38%. Comparing base (1b21d0c) to head (89ae69d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2234   +/-   ##
=========================================
  Coverage     37.37%   37.38%           
- Complexity    19784    19787    +3     
=========================================
  Files          1109     1109           
  Lines        169476   169491   +15     
  Branches      35801    35804    +3     
=========================================
+ Hits          63345    63356   +11     
+ Misses        96097    96095    -2     
- Partials      10034    10040    +6     
Files Coverage Δ
...sourceforge/kolmafia/session/ChoiceAdventures.java 34.35% <100.00%> (+0.05%) ⬆️
...et/sourceforge/kolmafia/session/LocketManager.java 86.84% <92.30%> (+1.12%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b21d0c...89ae69d. Read the comment docs.

@Veracity0 Veracity0 merged commit 3f5eacc into main Mar 12, 2024
8 checks passed
@Veracity0 Veracity0 deleted the decorate-locket branch March 12, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants