Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAdjustedHitStat return max for all stats if ATTACKS_CANT_MISS #585

Merged
merged 8 commits into from Feb 8, 2022
Merged

getAdjustedHitStat return max for all stats if ATTACKS_CANT_MISS #585

merged 8 commits into from Feb 8, 2022

Conversation

ckb11
Copy link
Contributor

@ckb11 ckb11 commented Feb 7, 2022

Move ATTACKS_CANT_MISS check before getHitStatType switch so that it applies for any hit stat (muscle, mysticality, or moxie)

@ckb11 ckb11 requested a review from a team as a code owner February 7, 2022 23:34
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #585 (463cc2b) into main (c73eab1) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #585      +/-   ##
============================================
- Coverage     20.92%   20.92%   -0.01%     
  Complexity     8943     8943              
============================================
  Files          1000     1000              
  Lines        156139   156139              
  Branches      34688    34688              
============================================
- Hits          32670    32667       -3     
- Misses       117534   117536       +2     
- Partials       5935     5936       +1     
Impacted Files Coverage Δ
...sourceforge/kolmafia/session/EquipmentManager.java 22.25% <0.00%> (ø)
...sourceforge/kolmafia/textui/langserver/Script.java 81.91% <0.00%> (-3.20%) ⬇️
src/net/sourceforge/kolmafia/Modifiers.java 58.28% <0.00%> (ø)
...rceforge/kolmafia/persistence/HolidayDatabase.java 33.88% <0.00%> (ø)
...orge/kolmafia/persistence/ConsumablesDatabase.java 63.84% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c73eab1...463cc2b. Read the comment docs.

@jaadams5
Copy link
Contributor

jaadams5 commented Feb 8, 2022

I'm approving because it does what it says it will do. But I am not merging since I just don't know that it is the right thing. So someone who is more certain than I am that the modifier applies to non-Muscle attacks can merge.

@gausie
Copy link
Contributor

gausie commented Feb 8, 2022

Let's merge it and see if anyone complains :)

@gausie gausie merged commit 64751b5 into kolmafia:main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants