Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value for no poison is Integer.MAX_VALUE, not 0. add .poison proxy record field #810

Merged
merged 3 commits into from
Jun 11, 2022

Conversation

Veracity0
Copy link
Contributor

Monsters with poison have a poison level from 1 to 6.
The lower the level, the more severe.
The value for "no poison" is Integer.MAX_VALUE, not 0.

Added $location.poison proxy record field, which is the most virulent poison a monster in that area has.

This is the issue for the following Bug Report:

https://kolmafia.us/threads/mafia-will-not-adventure-without-acquiring-an-anti-anti-antidote.27628/

@Veracity0 Veracity0 requested a review from a team as a code owner June 10, 2022 22:01
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #810 (688b2b5) into main (d3810d1) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #810      +/-   ##
============================================
- Coverage     25.12%   25.12%   -0.01%     
  Complexity    11379    11379              
============================================
  Files          1017     1017              
  Lines        159276   159281       +5     
  Branches      35034    35036       +2     
============================================
+ Hits          40012    40013       +1     
- Misses       111847   111851       +4     
  Partials       7417     7417              
Impacted Files Coverage Δ
...ge/kolmafia/textui/parsetree/ProxyRecordValue.java 33.08% <20.00%> (-0.10%) ⬇️
src/net/sourceforge/kolmafia/MonsterData.java 48.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3810d1...688b2b5. Read the comment docs.

@Veracity0 Veracity0 enabled auto-merge (squash) June 10, 2022 22:12
@Veracity0 Veracity0 merged commit 73e4918 into main Jun 11, 2022
@Veracity0 Veracity0 deleted the poison-fix branch June 11, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants