Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dinocore path stuff #992

Merged
merged 1 commit into from Aug 18, 2022
Merged

Dinocore path stuff #992

merged 1 commit into from Aug 18, 2022

Conversation

Veracity0
Copy link
Contributor

  1. AscensionPath.DINOSAURS

  2. KoLCharacter.inDinocore

  3. Only parse dinosaur description if in Dinocore

  4. Dinosaur modifier parsing test now verifies that the monster is the expected "base" monster with dinosaur/element random modifiers.

  5. Revamped a huge if-then-else chain into a switch statement.

  6. Adjust monster attributes based on dinosaur/element modifiers.

@Veracity0 Veracity0 requested a review from a team as a code owner August 18, 2022 21:31
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #992 (e39cc11) into main (f9a268c) will increase coverage by 0.00%.
The diff coverage is 23.96%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #992   +/-   ##
=========================================
  Coverage     27.60%   27.60%           
- Complexity    13081    13087    +6     
=========================================
  Files          1029     1029           
  Lines        160454   160478   +24     
  Branches      35274    35244   -30     
=========================================
+ Hits          44286    44300   +14     
- Misses       108042   108082   +40     
+ Partials       8126     8096   -30     
Impacted Files Coverage Δ
src/net/sourceforge/kolmafia/MonsterData.java 49.50% <15.59%> (+0.28%) ⬆️
src/net/sourceforge/kolmafia/AscensionPath.java 84.78% <100.00%> (+0.16%) ⬆️
src/net/sourceforge/kolmafia/KoLCharacter.java 51.71% <100.00%> (+0.02%) ⬆️
...sourceforge/kolmafia/request/AdventureRequest.java 40.12% <100.00%> (-0.13%) ⬇️
...forge/kolmafia/persistence/ConcoctionDatabase.java 46.74% <0.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a268c...e39cc11. Read the comment docs.

@jaadams5 jaadams5 merged commit daac32f into main Aug 18, 2022
@jaadams5 jaadams5 deleted the dinocore-path branch August 18, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants