Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine if menu is currently visible #22

Open
MKevin3 opened this issue Mar 5, 2015 · 3 comments
Open

Determine if menu is currently visible #22

MKevin3 opened this issue Mar 5, 2015 · 3 comments

Comments

@MKevin3
Copy link

MKevin3 commented Mar 5, 2015

Instead of having the menu flash hidden / shown if the menu is already on screen it would be nice to have an isVisible property / method so I can skip reshowing the already visible menu.

I tried doing a simple bit of code checking for _menuView != nil but since that is not set back to nil when the user clicks somewhere off the menu to cancel it this does not work.

Menu needs to track / be notified of being clicked off of so it can do _menuView = nil when that happens.

@DoctorG
Copy link

DoctorG commented Mar 6, 2015

I had the same problem…

See my fork: https://github.com/DoctorG/kxmenu https://github.com/DoctorG/kxmenu

Not perfect but it works.

On Mar 5, 2015, at 2:41 PM, MKevin3 notifications@github.com wrote:

Instead of having the menu flash hidden / shown if the menu is already on screen it would be nice to have an isVisible property / method so I can skip reshowing the already visible menu.

I tried doing a simple bit of code checking for _menuView != nil but since that is not set back to nil when the user clicks somewhere off the menu to cancel it this does not work.

Menu needs to track / be notified of being clicked off of so it can do _menuView = nil when that happens.


Reply to this email directly or view it on GitHub #22.

@MKevin3
Copy link
Author

MKevin3 commented Mar 6, 2015

After I posted I did a bit more work and got it going on my own but I really appreciate you sending the note. 
I also added support for dismissing the menu with animation. Most of that was already there, just needed a little exposure.
Kevin

 On Thursday, March 5, 2015 7:06 PM, "Gregory P. Moore, MD" <notifications@github.com> wrote:

I had the same problem…

See my fork: https://github.com/DoctorG/kxmenu https://github.com/DoctorG/kxmenu

Not perfect but it works.

On Mar 5, 2015, at 2:41 PM, MKevin3 notifications@github.com wrote:

Instead of having the menu flash hidden / shown if the menu is already on screen it would be nice to have an isVisible property / method so I can skip reshowing the already visible menu.

I tried doing a simple bit of code checking for _menuView != nil but since that is not set back to nil when the user clicks somewhere off the menu to cancel it this does not work.

Menu needs to track / be notified of being clicked off of so it can do _menuView = nil when that happens.


Reply to this email directly or view it on GitHub #22.


Reply to this email directly or view it on GitHub.

@DoctorG
Copy link

DoctorG commented Mar 6, 2015

Sure. It is a nice popover but could use some tweaking and the ability to easily customize it further would be great.

If you add anything great to it let me know.

On Mar 5, 2015, at 10:12 PM, MKevin3 notifications@github.com wrote:

After I posted I did a bit more work and got it going on my own but I really appreciate you sending the note.
I also added support for dismissing the menu with animation. Most of that was already there, just needed a little exposure.
Kevin

On Thursday, March 5, 2015 7:06 PM, "Gregory P. Moore, MD" notifications@github.com wrote:

I had the same problem…

See my fork: https://github.com/DoctorG/kxmenu https://github.com/DoctorG/kxmenu

Not perfect but it works.

On Mar 5, 2015, at 2:41 PM, MKevin3 notifications@github.com wrote:

Instead of having the menu flash hidden / shown if the menu is already on screen it would be nice to have an isVisible property / method so I can skip reshowing the already visible menu.

I tried doing a simple bit of code checking for _menuView != nil but since that is not set back to nil when the user clicks somewhere off the menu to cancel it this does not work.

Menu needs to track / be notified of being clicked off of so it can do _menuView = nil when that happens.


Reply to this email directly or view it on GitHub #22.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub #22 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants