Merge pull request #124 from komamitsu/remove-needless-thread

Remove needless thread
komamitsu · Mar 4, 2019 · 13c8c18 · 13c8c18
2 parents 22ca0f7 + 1aadf90
commit 13c8c18
Showing 1 changed file with 2 additions and 18 deletions.
diff --git a/fluency-core/src/main/java/org/komamitsu/fluency/flusher/Flusher.java b/fluency-core/src/main/java/org/komamitsu/fluency/flusher/Flusher.java
@@ -125,29 +125,13 @@ private void closeBufferQuietly()
     {
         LOG.trace("Closing the buffer");
 
-        ExecutorService executorServiceForBufferClose = Executors.newSingleThreadExecutor();
         try {
-            // TODO: Should remove this nonblocking operation?
-            Future<Void> future = executorServiceForBufferClose.submit(() -> {
-                buffer.close();
-                isTerminated.set(true);
-                return null;
-            });
-
-            future.get(config.getWaitUntilTerminated(), TimeUnit.SECONDS);
-        }
-        catch (InterruptedException e) {
-            LOG.warn("Failed to close the buffer", e);
-            Thread.currentThread().interrupt();
+            buffer.close();
         }
         catch (Throwable e) {
             LOG.warn("Failed to close the buffer", e);
         }
-        finally {
-            ExecutorServiceUtils.finishExecutorService(
-                    executorServiceForBufferClose,
-                    config.getWaitUntilBufferFlushed());
-        }
+        isTerminated.set(true);
     }
 
     private void closeIngesterQuietly()