Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadow jar to avoid jackson version incompatibility #34

Merged
merged 1 commit into from
Aug 25, 2016

Conversation

xerial
Copy link
Contributor

@xerial xerial commented Aug 20, 2016

Fluency uses jackson 2.7.x and it causes conflict with these projects:

To use fluency with these projects, we should relocate the jackson to another package. This PR creates fluency-shadow.jar, which contains all dependent jars and relocated jackson libraries.

@coveralls
Copy link

coveralls commented Aug 20, 2016

Coverage Status

Coverage decreased (-0.2%) to 86.646% when pulling 2563250 on xerial:shadow-jar into a215499 on komamitsu:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 86.646% when pulling 2563250 on xerial:shadow-jar into a215499 on komamitsu:master.

@komamitsu
Copy link
Owner

Cool. Thanks!

@komamitsu komamitsu merged commit b258ae1 into komamitsu:master Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants