Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential data loss #760

Merged
merged 2 commits into from Dec 17, 2023
Merged

Fix potential data loss #760

merged 2 commits into from Dec 17, 2023

Conversation

komamitsu
Copy link
Owner

@komamitsu komamitsu commented Dec 17, 2023

Fixes #743

The issue happens when the application executes the following steps:

  • catch an interruption
  • call Thread.currentThread.interrupt()
  • continue the processing not stopping the application

So, I think the possibility the issue occurs is quite low. But the error handling of Fluency should be fixed as the reporter said.

This PR fixed the potential data loss issue.

@komamitsu komamitsu marked this pull request as ready for review December 17, 2023 13:36
@komamitsu komamitsu merged commit 58f2197 into master Dec 17, 2023
10 checks passed
@komamitsu komamitsu deleted the fix-potential-data-loss branch December 17, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data loss in the Buffer after throwing an IOException inside moveRetentionBufferToFlushable() method
1 participant