You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The text was updated successfully, but these errors were encountered:
krukrue
changed the title
Filter operators isEmpty and isNotEmpty Non-functional
Filter operators isEmpty and isNotEmpty are Non-functional
Feb 22, 2024
Hi @krukrue thanks for example, I will investigate it.
btw isEmpty works correctly as value.length === 0 is an empty string check also, maybe not so obvious - but it is covered by tests and do not see the reason to write (value.length === 0 || value =='') as both comparisons do the same
I prepared demo to show it:
https://stackblitz.com/edit/table-filter-row-custom-editor-ts-vpjndu?file=Demo.tsx
Tip for improving https://github.com/komarovalexander/ka-table/blob/master/src/lib/Utils/CommonUtils.ts - in isEmpty function would be good to compare not only null or empty array, but empty string also.
Thank you.
The text was updated successfully, but these errors were encountered: