Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut endpoint implementation (retrieve) #238

Conversation

EdwinGuayacan
Copy link
Contributor

Fixes #218

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Co-authored-by: David Roldán <Odraxs@users.noreply.github.com>
@EdwinGuayacan EdwinGuayacan marked this pull request as ready for review January 6, 2023 15:58
@EdwinGuayacan EdwinGuayacan force-pushed the 218-cut-retrive-endpoint-implementation branch from e4d83ed to 446912e Compare January 6, 2023 16:00
Copy link
Member

@miguelnietoa miguelnietoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EdwinGuayacan @Odraxs really good job! 👏🏻

Missing tests for CutResponse type. More comments added

lib/chainweb/p2p/cut.ex Outdated Show resolved Hide resolved
lib/chainweb/p2p/cut_response.ex Outdated Show resolved Hide resolved
lib/chainweb/request.ex Show resolved Hide resolved
EdwinGuayacan and others added 2 commits January 6, 2023 15:12
Co-authored-by: Miguel Nieto A <39246879+miguelnietoa@users.noreply.github.com>
@EdwinGuayacan EdwinGuayacan merged commit afbef4b into kommitters:v0.13 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants