Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #5

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Update README #5

merged 2 commits into from
Apr 28, 2023

Conversation

Odraxs
Copy link
Contributor

@Odraxs Odraxs commented Apr 28, 2023

Description

Closes #2

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

miguelnietoa
miguelnietoa requested changes Apr 28, 2023
View reviewed changes
Copy link
Member

@miguelnietoa miguelnietoa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Odraxs we need to update kommitters/.template with kommitters/soroban.ex in several files. Please let's do it in this PR 👍🏻

README.md Outdated Show resolved Hide resolved
@Odraxs Odraxs merged commit 63bfe32 into kommitters:v0.1 Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelnietoa miguelnietoa miguelnietoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Odraxs @miguelnietoa