Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests against rails 6.0.0.beta3 #135

Closed
wants to merge 8 commits into from
Closed

Run tests against rails 6.0.0.beta3 #135

wants to merge 8 commits into from

Conversation

Spone
Copy link
Collaborator

@Spone Spone commented Mar 26, 2019

closes #118

@Spone Spone requested a review from florentferry March 26, 2019 04:49
Spone
Spone commented Mar 26, 2019
View reviewed changes
.travis.yml
@@ -14,6 +14,7 @@ gemfile:
- gemfiles/rails_5.0.x.gemfile
- gemfiles/rails_5.1.x.gemfile
- gemfiles/rails_5.2.x.gemfile
- gemfiles/rails_6.0.x.gemfile
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot to add this last time so the tests weren't actually run for Rails 6

@coveralls
Copy link

Pull Request Test Coverage Report for Build 775

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.448%
Totals Coverage Status
Change from base Build 755: 0.0%
Covered Lines: 180
Relevant Lines: 181
💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 26, 2019 •
edited

Pull Request Test Coverage Report for Build 791

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.448%
Totals Coverage Status
Change from base Build 755: 0.0%
Covered Lines: 180
Relevant Lines: 181
💛 - Coveralls

@Spone Spone self-assigned this Mar 26, 2019
@Spone
Copy link
Collaborator Author

Spone commented Mar 26, 2019

I had to drop support for Ruby 2.3 and 2.4 because ActiveSupport 6.0.0.beta3 requires Ruby 2.5

@Spone
Copy link
Collaborator Author

Spone commented Mar 26, 2019

Closed in favor of #134 that includes both these commits and fixes the tests.

@Spone Spone closed this Mar 26, 2019
@Spone Spone deleted the tests-rails-6.0.0.beta3 branch March 26, 2019 07:09
@Spone Spone removed the request for review from florentferry March 26, 2019 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Spone Spone

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests against Rails edge?
2 participants
@Spone @coveralls