Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove view_renderer chain assigment #134

Merged
merged 13 commits into from Mar 28, 2019

Conversation

3 participants
@agungyuliaji
Copy link
Contributor

commented Mar 17, 2019

close #133
close #118

i don't know if this change will affect to another part, but this quick fix it's work on my end

there is no view_renderer= in Rails 6.0.0.beta3

@Spone

This comment has been minimized.

Copy link
Collaborator

commented Mar 17, 2019

Hi @agungyuliaji, thanks for contributing!

As you can see in Travis CI, the tests do not pass, it's breaking some features. Do you want to try to fix it another way?

@coveralls

This comment has been minimized.

Copy link

commented Mar 17, 2019

Pull Request Test Coverage Report for Build 767

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.448%

Totals Coverage Status
Change from base Build 755: 0.0%
Covered Lines: 180
Relevant Lines: 181

💛 - Coveralls
2 similar comments
@coveralls

This comment has been minimized.

Copy link

commented Mar 17, 2019

Pull Request Test Coverage Report for Build 767

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.448%

Totals Coverage Status
Change from base Build 755: 0.0%
Covered Lines: 180
Relevant Lines: 181

💛 - Coveralls
@coveralls

This comment has been minimized.

Copy link

commented Mar 17, 2019

Pull Request Test Coverage Report for Build 767

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.448%

Totals Coverage Status
Change from base Build 755: 0.0%
Covered Lines: 180
Relevant Lines: 181

💛 - Coveralls
@coveralls

This comment has been minimized.

Copy link

commented Mar 17, 2019

Pull Request Test Coverage Report for Build 802

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.448%

Totals Coverage Status
Change from base Build 801: 0.0%
Covered Lines: 180
Relevant Lines: 181

💛 - Coveralls

@agungyuliaji agungyuliaji changed the title remove view_renderer and lookup_context assigment remove view_renderer chain assigment Mar 17, 2019

Spone added some commits Mar 26, 2019

@Spone Spone self-assigned this Mar 26, 2019

@Spone Spone self-requested a review Mar 26, 2019

@Spone Spone requested a review from florentferry Mar 26, 2019

@Spone

Spone approved these changes Mar 26, 2019

@Spone Spone requested a review from nicolas-brousse Mar 27, 2019

@Spone Spone merged commit 3aed172 into komposable:master Mar 28, 2019

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@agungyuliaji agungyuliaji deleted the agungyuliaji:patch-1 branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.