Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove view_renderer chain assigment #134

Merged
merged 13 commits into from
Mar 28, 2019
Merged

Conversation

agungyuliaji
Copy link
Contributor

@agungyuliaji agungyuliaji commented Mar 17, 2019

close #133
close #118

i don't know if this change will affect to another part, but this quick fix it's work on my end

there is no view_renderer= in Rails 6.0.0.beta3

@Spone
Copy link
Collaborator

Spone commented Mar 17, 2019

Hi @agungyuliaji, thanks for contributing!

As you can see in Travis CI, the tests do not pass, it's breaking some features. Do you want to try to fix it another way?

@coveralls
Copy link

coveralls commented Mar 17, 2019

Pull Request Test Coverage Report for Build 767

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.448%

Totals Coverage Status
Change from base Build 755: 0.0%
Covered Lines: 180
Relevant Lines: 181

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 767

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.448%

Totals Coverage Status
Change from base Build 755: 0.0%
Covered Lines: 180
Relevant Lines: 181

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 767

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.448%

Totals Coverage Status
Change from base Build 755: 0.0%
Covered Lines: 180
Relevant Lines: 181

💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 17, 2019

Pull Request Test Coverage Report for Build 802

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.448%

Totals Coverage Status
Change from base Build 801: 0.0%
Covered Lines: 180
Relevant Lines: 181

💛 - Coveralls

@agungyuliaji agungyuliaji changed the title remove view_renderer and lookup_context assigment remove view_renderer chain assigment Mar 17, 2019
@Spone Spone self-assigned this Mar 26, 2019
@Spone Spone self-requested a review March 26, 2019 07:07
@Spone Spone requested a review from florentferry March 26, 2019 07:15
@Spone Spone merged commit 3aed172 into komposable:master Mar 28, 2019
@agungyuliaji agungyuliaji deleted the patch-1 branch April 18, 2019 10:33
@robink
Copy link
Contributor

robink commented Aug 24, 2019

This has side effects on Rails 5.2, it breaks, certainly among others things, rendering outside komponent if komponent is used.

= c "my_komponent"
= render partial: "my_standard_partial" // will never be found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Rails 6 - undefined method `view_renderer=' Add tests against Rails edge?
4 participants