Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi packages #12

Merged
merged 34 commits into from
Apr 20, 2018
Merged

Multi packages #12

merged 34 commits into from
Apr 20, 2018

Conversation

komuw
Copy link
Owner

@komuw komuw commented Apr 20, 2018

  • separate kshaka into multiple packages
  • also create a http-transport package showing how to implement the Transport interface

@codecov-io
Copy link

codecov-io commented Apr 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@714954b). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #12   +/-   ##
=========================================
  Coverage          ?   65.43%           
=========================================
  Files             ?        4           
  Lines             ?      243           
  Branches          ?        0           
=========================================
  Hits              ?      159           
  Misses            ?       56           
  Partials          ?       28
Impacted Files Coverage Δ
protocol/acceptor.go 100% <ø> (ø)
protocol/inmem_transport.go 100% <ø> (ø)
protocol/inmem_store.go 57.14% <0%> (ø)
protocol/node.go 64.95% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714954b...d78c018. Read the comment docs.

@komuw komuw merged commit b1ffb01 into master Apr 20, 2018
@komuw komuw deleted the multi-packages branch April 20, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants