Acmev2

.circleci/config.yml

@@ -8,7 +8,7 @@ jobs:
     docker:
       # specify the version you desire here
       # use `-browsers` prefix for selenium tests, e.g. `3.6.1-browsers`
-      - image: circleci/python:2.7
+      - image: circleci/python:3.6
       # Specify service dependencies here if necessary
       # CircleCI maintains a library of pre-built images
       # documented at https://circleci.com/docs/2.0/circleci-images/
@@ -22,17 +22,18 @@ jobs:
       - run:
           name: install dependencies
           command: |
-           sudo pip install twine wheel pypandoc coverage yapf flake8 sewer mock tldextract apache-libcloud
+           sudo pip3 install twine wheel pypandoc coverage autopep8 pylint flake8 sewer mock tldextract apache-libcloud
 
       # run tests!
       - run:
           name: run tests
           command: |
-            find . -type f -name \*.pyc -delete | echo
+            find . -type f -name *.pyc -delete | echo
             coverage erase
-            coverage run --omit="*tests*,*.virtualenvs/*,*__init__*,*/usr/local/lib/python2.7/dist-packages*" -m unittest discover && bash <(curl -s https://codecov.io/bash)
+            coverage run --omit="*tests*,*.virtualenvs/*,*.venv/*,*__init__*,*/usr/local/lib/python2.7/dist-packages*" -m unittest discover && bash <(curl -s https://codecov.io/bash)
             coverage report --show-missing --fail-under=85
             flake8 .
+            pylint --enable=E --disable=W,R,C sewer/
 
       # run make upload
 

.github/CONTRIBUTING.md

@@ -18,20 +18,24 @@ derivative works of any Contribution, under the MIT License.
 - open an issue on this repo. In your issue, outline what it is you want to add and why.
 - install pre-requiste software:             
 ```shell
-apt-get -y install pandoc && pip install twine wheel pypandoc coverage yapf flake8 mock
+apt-get -y install pandoc && pip3 install -e .[dev,test]
 ```                   
 - make the changes you want on your fork.
 - your changes should have backward compatibility in mind unless it is impossible to do so.
 - add your name and contact(optional) to CONTRIBUTORS.md
 - add tests
-- format your code using [yapf](https://github.com/google/yapf):                      
+- format your code using [autopep8](https://pypi.python.org/pypi/autopep8):                      
 ```shell
-yapf --in-place --recursive --parallel --style "google" .
+autopep8 --experimental --in-place -r -aaaaaaaaaaa .
 ```                     
 - run [flake8](https://pypi.python.org/pypi/flake8) on the code and fix any issues:                      
 ```shell
 flake8 .
 ```                      
+- run [pylint](https://pypi.python.org/pypi/pylint) on the code and fix any issues:                      
+```shell
+pylint --enable=E --disable=W,R,C sewer/
+```    
 - run tests and make sure everything is passing:
 ```shell
 make test

.gitignore

@@ -29,6 +29,7 @@ README.html
 
 #Coverage
 .coverage
+htmlcov/
 
 # Setuptools distribution folder.
 /dist/

Makefile

@@ -5,7 +5,7 @@ upload:
 	@python setup.py sdist
 	@python setup.py bdist_wheel
 	@twine upload dist/* -r testpypi
-	@sudo pip install -U -i https://testpypi.python.org/pypi sewer
+	@pip3 install -U -i https://testpypi.python.org/pypi sewer
 
 uploadprod:
 	@rm -rf build
@@ -14,11 +14,12 @@ uploadprod:
 	@python setup.py sdist
 	@python setup.py bdist_wheel
 	@twine upload dist/*
-	@sudo pip install -U sewer
+	@pip3 install -U sewer
 
 test:
-	@find . -type f -name \*.pyc -delete | echo
-	@coverage erase
-	@coverage run --omit="*tests*,*.virtualenvs/*,*__init__*,*/usr/local/lib/python2.7/dist-packages*" -m unittest discover
-	@coverage report --show-missing --fail-under=85
-	@flake8 .
+	@printf "\n removing pyc files::\n" && find . -type f -name *.pyc -delete | echo
+	@printf "\n coverage erase::\n" && coverage erase
+	@printf "\n coverage run::\n" && coverage run --omit="*tests*,*.virtualenvs/*,*.venv/*,*__init__*,*/usr/local/lib/python2.7/dist-packages*" -m unittest discover
+	@printf "\n coverage report::\n" &&coverage report --show-missing --fail-under=85
+	@printf "\n run flake8::\n" && flake8 .
+	@printf "\n run pylint::\n" && pylint --enable=E --disable=W,R,C sewer/