Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acmev2 #73

Merged
merged 53 commits into from
Mar 13, 2018
Merged

Acmev2 #73

merged 53 commits into from
Mar 13, 2018

Conversation

komuw
Copy link
Owner

@komuw komuw commented Feb 27, 2018

Thank you for contributing to sewer.
Every contribution to sewer is important to us.
You may not know it, but you have just contributed to making the world a more safer and secure place.

Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to sewer, and sewer agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that sewer shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.

Now,

What(What have you changed?)

  • support acme version 2
  • remove structlog as a dependency(we now use the stdlib logging lib)
  • move the repo over to python3 from python2

Why(Why did you change it?)

TODO:

* support SAN
Repository owner deleted a comment Mar 5, 2018
* simplify cloudflare api
Repository owner deleted a comment Mar 5, 2018
Repository owner deleted a comment Mar 6, 2018
Repository owner deleted a comment Mar 6, 2018
* use standard lib logging lib
Repository owner deleted a comment Mar 9, 2018
@komuw
Copy link
Owner Author

komuw commented Mar 9, 2018

Hello @wilfriedjonker .

If you still use sewer as your letsencrypt client, would you mind testing that this branch and pull request will still work for you.

This Pull request adds support for ACME version2 and removes version 1 support.
Letsencrypt recently announced the availability of ACME v2(https://letsencrypt.org/2017/06/14/acme-v2-api.html)
And they have since created test endpoints(https://community.letsencrypt.org/t/staging-endpoint-for-acme-v2/49605)

I've also made a few other changes that I've been meaning to do for a while:

  1. I've ported sewer to python3, it is now developed using python3.
  2. I've also removed the logging library(structlog) that I was using in favour of the inbuilt stdlib logging library.

Repository owner deleted a comment Mar 12, 2018
Repository owner deleted a comment Mar 13, 2018
@komuw komuw merged commit f82b660 into master Mar 13, 2018
Repository owner deleted a comment Mar 13, 2018
@komuw komuw deleted the acmev2 branch March 15, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant