Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*.py: rename base64_of_acme_keyauthorization gave it a proper meaning… #81

Merged
merged 1 commit into from
Mar 12, 2018

Conversation

komuw
Copy link
Owner

@komuw komuw commented Mar 12, 2018

…ful name

Thank you for contributing to sewer.
Every contribution to sewer is important to us.
You may not know it, but you have just contributed to making the world a more safer and secure place.

Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to sewer, and sewer agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that sewer shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.

Now,

What(What have you changed?)

  • rename base64_of_acme_keyauthorization

Why(Why did you change it?)

  • gave it a proper meaningful name

@codecov
Copy link

codecov bot commented Mar 12, 2018

Codecov Report

Merging #81 into acmev2 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           acmev2     #81   +/-   ##
======================================
  Coverage    93.2%   93.2%           
======================================
  Files           5       5           
  Lines         427     427           
======================================
  Hits          398     398           
  Misses         29      29
Impacted Files Coverage Δ
sewer/client.py 94.69% <100%> (ø) ⬆️
sewer/dns_providers/auroradns.py 93.47% <100%> (ø) ⬆️
sewer/dns_providers/common.py 78.26% <100%> (ø) ⬆️
sewer/dns_providers/cloudflare.py 91.17% <100%> (ø) ⬆️

@komuw komuw merged commit 1d1fa21 into acmev2 Mar 12, 2018
@komuw komuw deleted the rename-acme-auth branch March 12, 2018 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant