-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small issue with combine Tashkeel. #31
Comments
Can that help fix issue #27 by any chance? |
I had an issue like that, and I think this one would fix it, can you try and let me know ? |
The Dec19 update seems to have fixed it. Thanks for the time you've put into it MohHeader. |
@MohHeader I'm not exactly sure about what all of RemoveTashkeel is doing, but would using something like Unicode Normalization help? I have a simple example of that here. |
RemoveTashkeel, doesn't completely removes it, but it do so as a temp state. I think "Unicode Normalization", is what I am trying to achieve through Combine Tashkeel Let me give you an example the solution is easy, just replace them both with a 1 unicode shape that combine both. I tried the example you listed, it only removes the Tashkeel |
@MohHeader That sounds a lot like Precomposed characters, but I don't think that's possible with Arabic characters. So RemoveTashkeel isn't actually removing it, it's finding the locations of each Tashkeel character? |
I am not the author of the original RemoveTashkeel function, I just edited it to support combined Tashkeel. |
Another Edit ( 4 Feb 2019 )
Edit ( 19Dec2018 )
Function is updated to fix some bugs.
Hi :)
I found a bug in my code submitted later,, if we have a word that contains شدة & the previous letter has a tashkeel, then the Shada will be assigned to the previous letter instead of the correct one.
I have to fix it
but if someone is searching for a fix until a Merge request is created
Just replace the RemoveTaskeel method
The text was updated successfully, but these errors were encountered: