fix(RELEASE-1150) add checks to fieldselectors #583
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
========================================
Coverage 84.09% 84.09%
========================================
Files 26 26
Lines 1635 1742 +107
========================================
+ Hits 1375 1465 +90
- Misses 182 192 +10
- Partials 78 85 +7 ☔ View full report in Codecov by Sentry. |
happybhati
force-pushed
the
release-1105
branch
2 times, most recently
from
80d21f3
to
cd111ab
Compare
|
/retest |
|
/retest |
1 similar comment
|
/retest |
davidmogar
reviewed
Oct 14, 2024
happybhati
force-pushed
the
release-1105
branch
from
cd111ab
to
193aa3d
Compare
johnbieren
approved these changes
Oct 15, 2024
This commit fixes the issue of FieldSelectors retrurn everything when argument is nill, added checks to each function using fieldselecor. Signed-off-by: Happy Bhati <hbhati@redhat.com>
happybhati
force-pushed
the
release-1105
branch
from
193aa3d
to
fc70fe4
Compare
|
New changes are detected. LGTM label has been removed. |
|
Thanks, @johnbieren, for your approval. @davidmogar Since you reviewed it earlier, please take a look whenever you get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue of FieldSelectors retrurning everything when the argument is nill, added checks to each function using field selector.