Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project information not being included in the maven poms #108

Merged
merged 4 commits into from
May 10, 2024

Conversation

dhoepelman
Copy link
Collaborator

@dhoepelman dhoepelman commented May 10, 2024

Bumps JVM version to 11 because that's now required by the publish plugin

@dhoepelman
Copy link
Collaborator Author

dhoepelman commented May 10, 2024

This seems to fix the artifacts locally, hopefully this is enough to satisfy sonatype now

The most important change is

        // before: create<MavenPublication>("mavenJava") {
        publications.withType(MavenPublication::class) {

kotlin multiplatform already creates its own publications, so this created a new separate incorrect one. This new one sets the metadata for all publications created by kotlin multiplatform

@dhoepelman dhoepelman merged commit d01ed2e into main May 10, 2024
1 check passed
@dhoepelman dhoepelman deleted the fix_artifacts branch May 10, 2024 18:01
lnhrdt pushed a commit to lnhrdt/konform that referenced this pull request May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant