[golang example] Use http.DefaultClient instead of your own client

[DanielHeath]

package main

import (
    "fmt"
    "strings"
    "net/http"
    "io/ioutil"
)

func main() {

    url := "http://mockbin.com/request?foo=bar&foo=baz"

    payload := strings.NewReader("{\"foo\": \"bar\"}")

    req, _ := http.NewRequest("POST", url, payload)

    req.Header.Add("cookie", "foo=bar; bar=baz")
    req.Header.Add("accept", "application/json")
    req.Header.Add("content-type", "application/json")

    res, _ := http.DefaultClient.Do(req)

    defer res.Body.Close()
    body, _ := ioutil.ReadAll(res.Body)

    fmt.Println(res)
    fmt.Println(string(body))

}

[montanaflynn]

Is there a benefit to this approach besides one less line? The httpsnippet project is using the client for a timeout option and I'll probably add a redirect option as well.

[DanielHeath]

Nothing wrong with it, it's just not idiomatic go (unless you use the client to do something).

[montanaflynn]

Thanks for the input. Like I said the underlying library has a timeout option so that's why it's there, I might make it as you suggest for when the option is not invoked or maybe just set a default timeout.

[ahmadnassri]

@Montana you could also make two separate implementations and let the user decide which they'd like to use.

also, this would be better suited as a discussion on https://github.com/Mashape/httpsnippet

[montanaflynn]

Closed with Kong/httpsnippet@45a0e36