Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent exception on note text not containing ':' #20

Merged
merged 1 commit into from Oct 24, 2017
Merged

Prevent exception on note text not containing ':' #20

merged 1 commit into from Oct 24, 2017

Conversation

JeffSolomon
Copy link
Contributor

No description provided.

@konomae
Copy link
Owner

konomae commented Dec 6, 2016

Thanks!

What is the exception?
Would you please write a test that reproduce it.

@coveralls
Copy link

coveralls commented Dec 7, 2016 •
edited

Coverage Status

Coverage remained the same at 90.657% when pulling 3ed9b2d on JeffSolomon:patch-1 into dd46846 on konomae:master.

@konomae
Copy link
Owner

konomae commented Oct 24, 2017

Thank you for the PR!
I understood why it is necessary.

If a secure note is Generic Note, there is no : in notes variable.

@konomae konomae merged commit d1ba8cc into konomae:master Oct 24, 2017
This was referenced Oct 24, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JeffSolomon @konomae @coveralls