Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow type_hooks for substituted objects of the same parent type #219

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
+4 −2
Open

Allow type_hooks for substituted objects of the same parent type #219

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dc4ea6d
Add type hook transformation function
SnijderC Feb 16, 2023
263a3e2
Modernise the type hook function
SnijderC Feb 16, 2023
6f9e858
Fix Union case.
SnijderC Feb 16, 2023
adbaca4
Run test suite, expected to fail.
SnijderC Feb 17, 2023
05c3f07
Place the logic in the _build_value function, avoid issues with inten…
SnijderC Feb 17, 2023
cd8434c
Don't use get_origin, introduced in 3.8
SnijderC Feb 17, 2023
957c1e7
Make code more self-explanatory
SnijderC Feb 17, 2023
19ec0b0
Don't introduce freezegun dependency
SnijderC Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions dacite/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,10 @@ def from_dict(data_class: Type[T], data: Data, config: Optional[Config] = None)
def _build_value(type_: Type, data: Any, config: Config) -> Any:
if is_init_var(type_):
type_ = extract_init_var(type_)
if type_ in config.type_hooks:
data = config.type_hooks[type_](data)
if not is_union(type_):
for th_type, func in config.type_hooks.items():
if is_subclass(th_type, type_):
data = func(data)
if is_optional(type_) and data is None:
return data
if is_union(type_):
Expand Down