-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Total refactor #31
Total refactor #31
Conversation
@konradhalas, I'm not sure that I'll be able to do it faster than a week (have a tight schedule this week), but I'm definitely interested in this. |
As for now, I don't like the commit messages, they are not descriptive. I think probably that you want to merge them into one if you cannot describe what you did clearly. |
Also, consider splitting import into groups: |
@rominf thank you, I want to merge it in a few days (probably during weekend) so it will be awesome if you could find some time.
I will squash everything into single commit.
Which file is wrong? I think that they are grouped as you said. I'm using PyCharm and it is done automatically. |
In test files you have the following (or something like that): import pytest
from dataclasses import dataclass, field
from typing import Any Please change it to: from dataclasses import dataclass, field
from typing import Any
import pytest |
Ha, interesting, this is because I was using Python 3.6 locally and I had |
This is a total refactor of
dacite
library.I split everything into smaller modules, now real unit testing is finally possible. I also changed the way of building data class, current solution is much more generic, e.g. it supports fields like
x: List[List[List[Union[int, X]]]]
@jasisz @bpeake-illuscio @rominf - It would be great if anyone of you could find the time to do a short code review.