Drop CLI Ruby 2.1.0 support, upgrade installer embedded Ruby to 2.5.0 #3272
Conversation
kke
changed the title
|
(Built pkg in dropbox |
|
@kke we should probably check that plugin deps work with ruby 2.5? |
|
2.2 is EOLing on 2018-03-31 |
kke
changed the title
kke
changed the title
|
I would consider tagging a .dev or .pre on this branch to test if the travis/jenkins baked .pkg and .deb both work. |
kke
force-pushed
the
chore/drop_ruby21
branch
from
670f43e
to
ea9c761
Compare
|
The 1.5.0.pre2 |
| tags: true | ||
| os: osx | ||
| repo: kontena/kontena | ||
| rvm: 2.4 |
There was a problem hiding this comment.
I did not want to change build environment in #3294 ... that's why 2.4 is still there. This does not affect target embedded ruby version.
There was a problem hiding this comment.
BTW wouldn't it be better to bake the server/agent images and CLI releases using the same ruby version used to run the e2e tests? That would be 2.4?
* travis * cleanup
kke
force-pushed
the
chore/drop_ruby21
branch
from
aa83ed3
to
7f1e3e8
Compare
|
Builds seem to work fine, tested the osx build and seems like basic stuff like cloud plugin are working. I think this is ready for merge. |
Ruby 2.1 release branch has been EOL since 2017-03-31
Dropping automated check run on ruby 2.1 and replacing with 2.5.0.
Also the MacOS .pkg installer now installs an embedded 2.5.0 ruby instead of 2.1.